This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Integration Tests to Docker PostgreSQL 13 / Maven Dependency Upgrades #133
Merged
hhund
merged 8 commits into
develop
from
issues/130_131_dependency_upgrades_postgres13_testing_with_docker
Oct 21, 2020
Merged
Integration Tests to Docker PostgreSQL 13 / Maven Dependency Upgrades #133
hhund
merged 8 commits into
develop
from
issues/130_131_dependency_upgrades_postgres13_testing_with_docker
Oct 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed learning test
Scripts will start postgres13 docker container at 127.0.0.1:54321 as expected for running dao and jetty integration junit tests. Start docker container if you want to manually run dao and jetty integration tests.
This was
linked to
issues
Oct 18, 2020
Closed
wetret
reviewed
Oct 20, 2020
...hir/dsf-fhir-server/src/test/java/org/highmed/dsf/fhir/profiles/OrganizationProfileTest.java
Show resolved
Hide resolved
wetret
reviewed
Oct 20, 2020
wetret
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that the build time is reduced significantly.
Maybe check the 2 comments.
Build times could further be improved. Currently every Jetty integration test class generates a number of X509 certificates and starts and stops a Jetty server. The server only needs to be started once per build and the certificates could even be reused between builds unless I created #134 to track this. |
hhund
deleted the
issues/130_131_dependency_upgrades_postgres13_testing_with_docker
branch
November 3, 2020 15:06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect the maven build time is reduced from 26m to about 8m
closes #130
closes #131