Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Integration Tests to Docker PostgreSQL 13 / Maven Dependency Upgrades #133

Conversation

hhund
Copy link
Member

@hhund hhund commented Oct 18, 2020

  • Modifies integration Jetty and DB tests to use docker postgres13 container during maven build
  • JUnit tests are executed during the maven test phase, JUnit integration tests are executed during the integration-test phase
  • Upgrades Maven dependencies to latest compatible versions
  • Adds bat and sh script to start postgres13 docker container to run dao and jetty integration tests manually

As a side effect the maven build time is reduced from 26m to about 8m

closes #130
closes #131

@hhund hhund added this to the v0.3.0 milestone Oct 18, 2020
Copy link
Member

@wetret wetret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that the build time is reduced significantly.
Maybe check the 2 comments.

@wetret wetret assigned wetret and unassigned wetret Oct 20, 2020
@hhund
Copy link
Member Author

hhund commented Oct 20, 2020

Very nice that the build time is reduced significantly.

Build times could further be improved. Currently every Jetty integration test class generates a number of X509 certificates and starts and stops a Jetty server. The server only needs to be started once per build and the certificates could even be reused between builds unless mvn clean is called. We might even want to think about using a docker container to start the Jetty server since we now depend on docker during the build anyways.

I created #134 to track this.

@hhund hhund merged commit c71d96c into develop Oct 21, 2020
@hhund hhund deleted the issues/130_131_dependency_upgrades_postgres13_testing_with_docker branch November 3, 2020 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Dependencies Migrate Integration Tests to Use PostgreSQL 13
2 participants