Properly handle DM channels in resolved interaction channels (#1628)

hikari-py · Jun 4, 2023 · 9878537 · 9878537
1 parent 0b40380
commit 9878537
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/changes/1628.bugfix.md b/changes/1628.bugfix.md
@@ -0,0 +1 @@
+Properly handle DM channels in resolved interaction channels.
diff --git a/hikari/impl/entity_factory.py b/hikari/impl/entity_factory.py
@@ -2454,12 +2454,20 @@ def _deserialize_resolved_option_data(
         if raw_channels := payload.get("channels"):
             for channel_payload in raw_channels.values():
                 channel_id = snowflakes.Snowflake(channel_payload["id"])
+
+                # Even tho (at the time of writing) it is documented that these partial channels will always contain
+                # this field, they are explicitly avoided for DM channels.
+                if "permissions" in channel_payload:
+                    permissions = permission_models.Permissions(int(channel_payload["permissions"]))
+                else:
+                    permissions = permission_models.Permissions.NONE
+
                 channels[channel_id] = base_interactions.InteractionChannel(
                     app=self._app,
                     id=channel_id,
                     type=channel_models.ChannelType(channel_payload["type"]),
-                    name=channel_payload["name"],
-                    permissions=permission_models.Permissions(int(channel_payload["permissions"])),
+                    name=channel_payload.get("name"),
+                    permissions=permissions,
                 )
 
         if raw_users := payload.get("users"):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Properly handle DM channels in resolved interaction channels.