Allow for custom $-substitutions in hikari.internal.ux.print_banner
#1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
reviewed
Feb 17, 2022
|
https://github.com/hikari-py/hikari/blob/master/hikari/impl/bot.py#L652 Signature needs to be updated here too. But rest looks ok 👍 |
|
i've updated the signatures |
davfsa
reviewed
Feb 18, 2022
davfsa
reviewed
Feb 18, 2022
davfsa
approved these changes
Feb 18, 2022
FasterSpeeding
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1006
Allows custom $-substitutions to be used when printing a banner.
Checklist
noxand all the pipelines have passed.Related issues