Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale bugs and regressions #1101

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Fix locale bugs and regressions #1101

merged 1 commit into from
Mar 25, 2022

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Mar 25, 2022

Summary

Fix some bugs and a regression introduced by #1090.

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

@davfsa davfsa added bug Something isn't working skip-fragment-check Skip fragment checks for this PR as it doesnt need one labels Mar 25, 2022
@davfsa davfsa requested a review from FasterSpeeding March 25, 2022 18:24
@davfsa davfsa enabled auto-merge (squash) March 25, 2022 18:24
Le0Developer
Le0Developer reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Le0Developer Le0Developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning my mess up 😅

hikari/impl/entity_factory.py Outdated Show resolved Hide resolved
@davfsa davfsa force-pushed the task/fix-locale-regressions branch from 792abbd to 1d9c4e1 Compare March 25, 2022 19:23
@davfsa davfsa force-pushed the task/fix-locale-regressions branch from 1d9c4e1 to ce52f3b Compare March 25, 2022 21:04
FasterSpeeding
FasterSpeeding previously approved these changes Mar 25, 2022
View reviewed changes
@davfsa davfsa force-pushed the task/fix-locale-regressions branch from ce52f3b to 43e3270 Compare March 25, 2022 21:50
@davfsa davfsa merged commit 3557c3a into hikari-py:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Le0Developer Le0Developer Le0Developer left review comments

@FasterSpeeding FasterSpeeding FasterSpeeding approved these changes

Assignees
No one assigned
Labels
bug Something isn't working skip-fragment-check Skip fragment checks for this PR as it doesnt need one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davfsa @FasterSpeeding @Le0Developer