Remove case of bang (!) from Member.mention property

changes/1207.breaking.md

@@ -0,0 +1 @@
+Removed case of `Member.mention` returning bang (`!`) mention, as it is deprecated by Discord.

hikari/guilds.py

@@ -484,28 +484,7 @@ def is_system(self) -> bool:
 
     @property
     def mention(self) -> str:
-        """Return a raw mention string for the given member.
-
-        If the member has a known nickname, we always return
-        a bang ("`!`") before the ID part of the mention string. This
-        mimics the behaviour Discord clients tend to provide.
-
-        Example
-        -------
-
-        ```py
-        >>> some_member_without_nickname.mention
-        '<@123456789123456789>'
-        >>> some_member_with_nickname.mention
-        '<@!123456789123456789>'
-        ```
-
-        Returns
-        -------
-        builtins.str
-            The mention string to use.
-        """
-        return f"<@!{self.id}>" if self.nickname is not None else self.user.mention
+        return self.user.mention
 
     def communication_disabled_until(self) -> typing.Optional[datetime.datetime]:
         """Return when the timeout for this member ends.

tests/hikari/test_guilds.py

@@ -485,11 +485,7 @@ def test_display_name_property_when_no_nickname(self, model, mock_user):
         model.nickname = None
         assert model.display_name is mock_user.username
 
-    def test_mention_property_when_nickname(self, model):
-        assert model.mention == "<@!123>"
-
-    def test_mention_property_when_no_nickname(self, model, mock_user):
-        model.nickname = None
+    def test_mention_property(self, model, mock_user):
         assert model.mention == mock_user.mention
 
     def test_get_guild(self, model):