Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Eliminate Known issues in Simplifier #105

Merged
merged 14 commits into from
Sep 19, 2024
Merged

[BugFix] Eliminate Known issues in Simplifier #105

merged 14 commits into from
Sep 19, 2024

Conversation

hikettei
Copy link
Owner

@hikettei hikettei commented Sep 18, 2024 •
edited
Loading

  • Graphs that were needed are removed. (GPT2 and Static)
  • Removed necessary nodes error (Dynamic) + Symbolic GPT2 Compilation
  • Fix: Model -> IR Lowering. (replace call in source/apis/initializer.lisp w/ forward, as well as activation)
  • Lowering the nested call

@hikettei
Copy link
Owner Author

hikettei commented Sep 18, 2024 •
edited
Loading

repro: (defmethod call ... (forward ... (forward))

  • Add FeedForward to the unittest
  • Residual Connection Test
  • ./test-suites/test-transformer.lisp
  • ./test-suites/test-lowerer.lisp

@hikettei

This comment was marked as outdated.

Sign in to view
@hikettei hikettei marked this pull request as ready for review September 19, 2024 04:57
@hikettei hikettei merged commit 64b6c6b into main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hikettei