Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!reshape always use !contiguous #120

Merged
merged 11 commits into from
Sep 29, 2024
Merged

!reshape always use !contiguous #120

merged 11 commits into from
Sep 29, 2024

Conversation

hikettei
Copy link
Owner

@hikettei hikettei commented Sep 29, 2024 •
edited
Loading

  • Fix for broadcasted+matmul+transpose
  • !reshape always comes with !contiguous
  • More Restrict Scheduling Tests (explicit kernel counts and tensor counts to all nn ops)
    • ScaledDotProductAttention
    • FeedForward
    • RMSNorm
    • Embedding
    • Matmul (Symbolic)
  • Index計算をFoldしないといけない ... (In Scheduling + Loop Fusion)
    • LoopのBoundがb==val_xxxと推論されてるから，symbolic matmulがうまくFoldされない
  • Fix: Symbolic Embedding (due to ISL)
  • Optimize: Zero-Cost Transpose in JIT

@hikettei hikettei changed the title WIP: Zero-Cost Transpose !reshape always use !contiguous Sep 29, 2024
@hikettei hikettei marked this pull request as ready for review September 29, 2024 04:07
@hikettei
Copy link
Owner Author

TODO: Fuse this pattern:

MOVE MOVE
 \     /
 WMMA

@hikettei hikettei merged commit 083e871 into main Sep 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hikettei