selu, softmin and hardtanh #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so the ci looks failing due to a compiler's bug. it is valuable for us to discovery new bugs so thank you for your contributions. i will dig deeper into this issue once I finish my current task. |
|
the problem is in softmin+JIT=1, failing to run this jit-generated function |
|
solved at #190 |
hikettei
requested changes
Nov 9, 2024
| (define-nn-test Softmin | ||
| "Testing w/ Softmin([512, 256])" | ||
| :compile (caten (!softmin (make-tensor `(512 256) :from 'x))) | ||
| :inputs (ctx:with-contextvar (:jit 0 :avm :lisp) |
There was a problem hiding this comment.
no need to set (ctx:with-contextvar (:jit 0 :avm :lisp) here
There was a problem hiding this comment.
hmm is that line needed? if so im fine with leaving this line (but add a comment plz)
hikettei
reviewed
Nov 9, 2024
|
looks clean! LGTM! |
hikettei
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.