Add "types" condition to "exports" in package.json.
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package.json` has a `"types"` field which points to `./types/util.d.ts`. But it also has an `"exports"` field. The `"exports"` field, when provided, is supposed to supersede fields like `"main"` and `"browser"`. TypeScript respects this as well, and ignores the `"types"` field when `"exports"` is present. Due to this, the latest version of TypeScript will ignore the `"types"` field, giving the following error: > error TS7016: Could not find a declaration file for module 'node-inspect-extracted'. 'node_modules/.pnpm/[email protected]/node_modules/node-inspect-extracted/index.mjs' implicitly has an 'any' type. It also follows up with the following message: > There are types at 'node_modules/node-inspect-extracted/types/util.d.ts', but this result could not be resolved when respecting package.json "exports". The 'node-inspect-extracted' library may need to update its package.json or typings. This PR resolves this issue by adding a `"types`" condition to the `"exports"` field which matches the existing top-level `"types"` field.
|
Thanks. I will bring the current code up to match the latest node version and do a release tomorrow. |
|
Fixed in 3.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package.jsonhas a"types"field which points to./types/util.d.ts. But it also has an"exports"field. The"exports"field, when provided, is supposed to supersede fields like"main"and"browser". TypeScript respects this as well, and ignores the"types"field when"exports"is present.Due to this, the latest version of TypeScript will ignore the
"types"field, giving the following error:It also follows up with the following message:
This PR resolves this issue by adding a
"types"condition to the"exports"field which matches the existing top-level"types"field.