Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Settings layout #117

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Made Settings layout #117

merged 1 commit into from
Mar 13, 2021

Conversation

anotherwebguy
Copy link
Contributor

@anotherwebguy anotherwebguy commented Mar 13, 2021

Related Issue

  • Fixes # 38 making seetings screen layout

Proposed Changes

-Made Settings screen layout

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation

Screenshots

image

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Mar 13, 2021
@himanshusharma89 himanshusharma89 added the Level2 medium gssoc issue label Mar 13, 2021
@himanshusharma89 himanshusharma89 merged commit 826bc59 into himanshusharma89:master Mar 13, 2021
@himanshusharma89
Copy link
Owner

@anotherwebguy Don't create PR from the master branch from next time.

@anotherwebguy
Copy link
Contributor Author

anotherwebguy commented Mar 13, 2021

@anotherwebguy Don't create PR from the master branch from next time.

Yeah i'll keep that in mind. Thanks @himanshusharma89

@anotherwebguy
Copy link
Contributor Author

@anotherwebguy Don't create PR from the master branch from next time.

Now can i work on some other functionality in the settings screen?

@himanshusharma89
Copy link
Owner

@anotherwebguy Don't create PR from the master branch from next time.

Now can i work on some other functionality in the settings screen?

For the functionality to work we need to cover the authentication and other features. For now, we need to focus on the UI

@anotherwebguy
Copy link
Contributor Author

@anotherwebguy Don't create PR from the master branch from next time.

Now can i work on some other functionality in the settings screen?

For the functionality to work we need to cover the authentication and other features. For now, we need to focus on the UI

Yeah i mean the ui like i can make the change address screen by providing location picker, the user can choose hi current location to pick or he/she can manually type it

@himanshusharma89
Copy link
Owner

@anotherwebguy Go ahead mention it in the issue, I'll update the description and assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 Issues created for GSSOC'21 Level2 medium gssoc issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants