Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the change username and password screen #150

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Added the change username and password screen #150

merged 3 commits into from
Mar 25, 2021

Conversation

Samdid
Copy link
Contributor

@Samdid Samdid commented Mar 22, 2021

Related Issue

Proposed Changes

  • added the change username and password screen

Additional Information

  • Any additional information about the change

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation
  • Follows linting rules

Screenshots

After this PR
** Updated Screenshot **
Screenshot_1616438311

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Mar 22, 2021
@Samdid
Copy link
Contributor Author

Samdid commented Mar 22, 2021

@himanshusharma89 Please review and merge this PR.

@himanshusharma89
Copy link
Owner

@Samdid Can you not ignore the warnings and resolve them?

@Samdid
Copy link
Contributor Author

Samdid commented Mar 23, 2021

@Samdid Can you not ignore the warnings and resolve them?

I didn't found any warning

@himanshusharma89
Copy link
Owner

I didn't found any warning

You ignored all of them, remove all the // ignore comments and resolve the warnings.

@Samdid
Copy link
Contributor Author

Samdid commented Mar 23, 2021

I didn't found any warning

You ignored all of them, remove all the // ignore comments and resolve the warnings.

Okay

@himanshusharma89 himanshusharma89 added the Level2 medium gssoc issue label Mar 23, 2021
@himanshusharma89
Copy link
Owner

@Samdid Pull the latest code before working on it.

@Samdid
Copy link
Contributor Author

Samdid commented Mar 24, 2021

@Samdid Pull the latest code before working on it.

Do I have to remove all the warnings or just from the file which I have created?

@himanshusharma89
Copy link
Owner

@Samdid Pull the latest code before working on it.

Do I have to remove all the warnings or just from the file which I have created?

From your files only.

@Samdid
Copy link
Contributor Author

Samdid commented Mar 24, 2021

@Samdid Pull the latest code before working on it.

Do I have to remove all the warnings or just from the file which I have created?

From your files only.

Okay👍

Samdid added 2 commits March 25, 2021 12:21
@Samdid
Merge branch 'master' of https://github.com/himanshusharma89/relic_ba…
5051643 
…zaar into changeUsername

� Conflicts:
�	lib/main.dart
�	lib/views/settings.dart
@Samdid
resolved all the warnings
a7f57e7
@Samdid
Copy link
Contributor Author

Samdid commented Mar 25, 2021

@himanshusharma89 resolved all the warnings and also pulled the latest code

@himanshusharma89 himanshusharma89 merged commit 3c55640 into himanshusharma89:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Samdid Samdid

Labels
GSSOC21 Issues created for GSSOC'21 Level2 medium gssoc issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings Screen
2 participants
@Samdid @himanshusharma89