Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requirements for contracts deployed with multisig #1394

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

friedger
Copy link
Contributor

Description

Calling clarinet check fails when the Clarinet.toml file includes requirements with contracts deployed from a multisg.

Example

lisalab-io/liquid-stacking#39

Checklist

  • Tests added in this PR (if applicable)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.87%. Comparing base (9fba411) to head (6eafcce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   40.86%   40.87%           
=======================================
  Files          87       87           
  Lines       32560    32562    +2     
=======================================
+ Hits        13307    13309    +2     
  Misses      19253    19253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard
Copy link
Collaborator

Good catch! Thanks for the fix @friedger
I'll release today as Clarinet 2.4.1

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @friedger!

@hugocaillard hugocaillard enabled auto-merge (squash) March 27, 2024 10:39
@hugocaillard hugocaillard disabled auto-merge March 27, 2024 14:29
@hugocaillard hugocaillard enabled auto-merge (squash) March 27, 2024 14:29
@hugocaillard hugocaillard disabled auto-merge March 27, 2024 14:29
@hugocaillard hugocaillard merged commit 807c738 into hirosystems:main Mar 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants