-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to serde 1.0 #24
Conversation
Any updates on this? Does this project have any maintainers? |
# specify rate in requests/second | ||
// specify rate in requests/second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose in changing this comment type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so the markdown test generator turns code blocks into doctests, and I was really confused about why there was a parse error in hjson until I realized that #
is a special character in doctests, and apparently even in string literals! Like for:
/// Example
/// ```
/// # use foo::Bar;
/// Bar::baz();
/// ```
struct Bar;
The use
line would get compiled in the doctests, but it would be hidden in the generated documentation. So basically, rustdoc was recognizing the #
as a special character and just removing it, which would lead to the string literal missing the #
and hjson failing to parse a line of just specify rate in requests/second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait, and thank you so much for all your work on this PR! I only had one comment about a change you made to the doc, but otherwise it looks good.
can this be merged? the current code doesn't work with 1.6 rustc, things need to be updated |
Merging, sorry for the long wait. |
No description provided.