Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to serde 1.0 #24

Merged
merged 5 commits into from
Jul 20, 2024
Merged

Upgrade to serde 1.0 #24

merged 5 commits into from
Jul 20, 2024

Conversation

coolreader18
Copy link
Contributor

No description provided.

@dessalines
Copy link

Any updates on this? Does this project have any maintainers?

# specify rate in requests/second
// specify rate in requests/second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose in changing this comment type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so the markdown test generator turns code blocks into doctests, and I was really confused about why there was a parse error in hjson until I realized that # is a special character in doctests, and apparently even in string literals! Like for:

/// Example
/// ```
/// # use foo::Bar;
/// Bar::baz();
/// ```
struct Bar;

The use line would get compiled in the doctests, but it would be hidden in the generated documentation. So basically, rustdoc was recognizing the # as a special character and just removing it, which would lead to the string literal missing the # and hjson failing to parse a line of just specify rate in requests/second

Copy link
Member

@dqsully dqsully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, and thank you so much for all your work on this PR! I only had one comment about a change you made to the doc, but otherwise it looks good.

@shi-yan
Copy link

shi-yan commented Apr 15, 2022

can this be merged? the current code doesn't work with 1.6 rustc,

things need to be updated

@tishun
Copy link

tishun commented Jul 13, 2024

@dqsully and @trobro I started doing the same thing and ended up with a nearly identical solution.
Do we want to merge this?

@trobro trobro merged commit 293ef7d into hjson:master Jul 20, 2024
@trobro
Copy link
Member

trobro commented Jul 20, 2024

Merging, sorry for the long wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants