Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous binding in DKCorePatient #152

Closed
TMHA-Trifork opened this issue Jan 13, 2025 · 4 comments
Closed

Erroneous binding in DKCorePatient #152

TMHA-Trifork opened this issue Jan 13, 2025 · 4 comments
Assignees

Comments

@TMHA-Trifork
Copy link

Patient.contact .relationship is bound to the valueset DK Related Person Relationship Types (https://github.com/hl7dk/dk-core/issues/ValueSet-dk-core-RelatedPersonRelationshipTypes.html), which seems to be conflicting with the standard FHIR R4 binding as the profiled value set does not contain any of the codes in the extensible binding.

@jkiddo
Copy link
Collaborator

jkiddo commented Jan 13, 2025

I think the binding was accidently introduced here: 711d923

jkiddo added a commit that referenced this issue Jan 13, 2025
Created DK supplement for standard codesystem
@jkiddo
Copy link
Collaborator

jkiddo commented Jan 13, 2025

The easy fix is to fix it in 3.4.0 and then merge that into 3.5.0

@TMHA-Trifork
Copy link
Author

I vaguely remember having a discussion in the FHIR SIG about this concluding that having the same value set as for relatives would be feasible, but it breaks the basic rule in FHIR. Do we have a track of this in in a meeting summary about that time @RikkeVestesen

@TMHA-Trifork TMHA-Trifork self-assigned this Jan 27, 2025
@TMHA-Trifork
Copy link
Author

Decision: Create new valueset with current values and add the ones from the extensible valueset from the FHIR standard and use that on the contact relation type.

jkiddo added a commit that referenced this issue Jan 27, 2025
jkiddo added a commit that referenced this issue Feb 1, 2025
* Added Location and PractitionerRole

* fatfingered a '*'

* Moved NPU subset into its own Code System fragment.

* Remove special treatment of NPU

* Testing out fragments for NPU

* Adjusted unicodes

* Corrected descriptions

* Mapped "comments" using https://hl7.org/fhir/codesystem.html#defined-props

* Added correct property concept values

* Removed locale duplicate displays
Made SCT alias target DK by default

* Refined used of DK profiles

* indented properties

* Reintroduced special url for NPU to remove IGP error.

* Feature ipa support (#132)

* Introduced IPA support

* Update dep of IPA

* Adjusted to 1.0.0

* Removed merge files

* Added compliesWith and child profile for IPA compliance (#133)

* Changed to imposeProfile

* Update release-notes.md

* Update release-notes.md

* Added proper base definition

* Fix: Changed to assignment instead of declaration of imposeProfile

* Update DkCoreObservation.fsh

* Initial commit of ServiceRequest

* Update DkCoreServiceRequest.fsh

* Added content for ServiceRequest

* Update DkCoreServiceRequest.fsh

* Added ignores for NPU-errors

* Update name of profile and content of DkCoreServiceRequestCodes

* priority valueset, reasoncode and reason reference added to ServiceRequest

* changed slice name

* Update StructureDefinition-dk-core-servicerequest-intro.md

* Updated name of intro-file

* Update valueSets.fsh

* ServiceRequest coding updated in the profile, as well as in the documentation.

* ServiceRequest example corrected, documentation for priority and reasonCode added

* Updated scope and usage section according to #136

* Updated scope and usage section according to #135

* added to relationship value set and code system supplement to account for #135 and #134

* Handled issues from consultation

#140, #139, #137

* Update StructureDefinition-dk-core-patient-intro.md

#138

* Update DkCorePatient.fsh

#126

* Update DkCorePatient.fsh

#126

* Updated ServiceRequest ValueSet

* Updated scope and usage section according to #136

* Updated scope and usage section according to #135

* added to relationship value set and code system supplement to account for #135 and #134

* Update DkCorePatient.fsh

#126

* Fixed NPU error codes

* no message

* doc start on IPA inspired by fhir.fh

* Added parts of documentation

* Fixed note templates

* Disabling gh builds as they are not needed.
Added documentation

* Updated Continua/PHD examples to latest PHD release and fixed license-messages and other QA issues

* Fixed some obvious QA warnings: IPA patient and practitioner names should have a .text element and UCUM units with annotations should have the display value including the annotation

* Handled comments from review

* Updated reference to DkCorePractitionerRole

* Separated the IPA profiles into their own file

* Change listing of profiles

* Adjusted naming

* Fixed bugs

* A bit of layout changes

* Added kebab cased id's.

* Added textual descriptions to IPA profiles

* Fixed link

* Removed wrong valueset binding - #152
Created DK supplement for standard codesystem

* Removed QA error

* Update release-notes.md

* Update publication-request.json

* syntax ...

* Update codeSystems.fsh

* Correction to #152

* Removed QA errors

* removed IG version warning

* Fixed spelling error

---------

Co-authored-by: tmsMedcom <[email protected]>
Co-authored-by: kirstinerosenbeck <[email protected]>
Co-authored-by: Christian Gasser <[email protected]>
Co-authored-by: Jacob Andersen <[email protected]>
Co-authored-by: hagensen-software <[email protected]>
@jkiddo jkiddo closed this as completed Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants