Allow Builder to specify a default short_message
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the default `short_message` was a empty string, which causes Graylog to throw an `IllegalArgumentException` (see hlbarber#15). This changes the default message to `"no message"` and adds a `Builder::default_short_message()` member function to change the default.
|
@hlb8122, would it still be possible to merge this PR, based on your feedback in #15? Thank you! |
Yep will merge and release today. Thanks for your patience. |
|
Going to change the default to |
No objection. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default
short_messagewas a empty string, which causes Graylog to throw anIllegalArgumentException(see #15). This changes the default message to"no message"and adds aBuilder::default_short_message()member function to change the default.This Pull Request supercedes and closes #15.