Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #426 #476

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fixed issue #426 #476

merged 2 commits into from
Aug 28, 2024

Conversation

MagicBOTAlex
Copy link
Contributor

@MagicBOTAlex MagicBOTAlex commented Aug 26, 2024

This might be a patch for the problem, but it works.
I noticed that Blender doesn't update the UI after creating a new workplane.

Before

blender_vjybzlzsDG
I noticed that it creates the new workplanes, but doesn't update the changes.

After

blender_iYdK64yN76
This is when I force the update after the workplane creation

Windows
Blender 4.0
CAD_Sketcher: latest
(I don't want the bounty. Too much for such a small change)

Edit: Hmm, I just thought about it. It might cause some performance problems for bigger projects. But at least I found the problem.

With that said, I'm not sure if it's avoidable to not re-draw.

This might be a patch for the problem, but it works
@hlorus
Copy link
Owner

hlorus commented Aug 27, 2024

Thanks for the PR, this is looking good. The only note i have is that you'll likely don't need to loop through all areas but can just access the one that is set in the context, e.g.:
context.area.tag_redraw()

@MagicBOTAlex
Copy link
Contributor Author

Ohh, that's what "context" was. But it seems to be working. 👍

@hlorus hlorus merged commit 95e50be into hlorus:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants