-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dracula plugin sets the color of labels #10
Comments
Hi all, I've implemented a fix for this but it means that readability of a model suffers as you can see in the before and after with and without the fix. (likely why @hlucasfranca purposely chose to overwrite the label text for readability). Example model without the plugin: Example model with the plugin (without this fix): Example model with the plugin (with this fix): I think it is important to main the colorization of labels as those are generally set to provide some contextual meaning in the model - highlight NIGO routes as an example; however, the Camunda Modeler's chose of dark colors for labels does not play nicely with the dark backgrounds. Off the top of my head I think of a couple of solutions to this:
Open to brainstorming and ideas @hlucasfranca @t1 |
If there is no direct way to change the color of labels in Camunda Modeller, I'd say this plugin is doomed. I don't think that either option is acceptable. Changing to dark-mode must be a viewer-only decision. So IIUC, we require a PR to the Modeller itself? |
I don't see why you would say this plugin is "doomed". This plugin is only changing how the model is visually displayed. It is in now way changing the XML of the BPMN model. You can change the colors of labels in the model from a choice of 6 colors in the modeler . This is functionality provided by the modeler app. The question I've proposed is regarding what is the best way to visually display the colors in a way that coalesces with a dark theme for readability since those provided 6 colors are rather dark and aren't easily visible on a dark background. We don't need an update from the modeler to achieve any of this just a decision on which direction to take. |
Sorry. Maybe I go you wrong. Can we just provide 6 alternate Dracula colors? They should have a similar hue, so "yellow" is still "yellow". And IIUC these color don't only apply to labels. |
(moved from camunda/camunda-modeler-plugins#108)
Describe the Bug
When I edit a BPMN model with the Dracula plugin installed, it changes the color of all labels from:
to:
Steps to Reproduce
Expected Behavior
It should never change the color in the BPMN.
Environment
The text was updated successfully, but these errors were encountered: