Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccd 5647 mismatch for CCD-5233 #1494

Merged

Conversation

patelila
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • the keep-helm label has been added, if the helm release should be persisted after a successful build

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

…uired to compare an unordered collection, please add an `__elementId__` to field 'accessTypes.roles' in your expected response body, or change to an ordered comparison
…s[BEFTA_MASTER] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_2] contains a bad value: roles[0] contains a bad value: Must not be null: groupRoleName

               actualResponse.body contains a bad value: jurisdictions[BEFTA_MASTER] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_2] contains a bad value: roles[0] contains a bad value: Must not be null: caseGroupIdTemplate
…s[BEFTA_JURISDICTION_1] contains a bad value: accessTypes[SOLICITOR_PROFILE__X__BEFTA_SOLICITOR_1__X__null] contains a bad value: roles[CaseAccessGroups_Casetype] contains a bad value: Must not be null: groupRoleName

               actualResponse.body contains a bad value: jurisdictions[BEFTA_JURISDICTION_1] contains a bad value: accessTypes[SOLICITOR_PROFILE__X__BEFTA_SOLICITOR_1__X__null] contains a bad value: roles[CaseAccessGroups_Casetype] contains a bad value: Must not be null: caseGroupIdTemplate
               actualResponse.body contains a bad value: jurisdictions[BEFTA_JURISDICTION_1] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_1__X__null] contains a bad value: roles[CaseAccessGroups_Casetype] contains a bad value: Must not be null: groupRoleName
               actualResponse.body contains a bad value: jurisdictions[BEFTA_JURISDICTION_1] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_1__X__null] contains a bad value: roles[CaseAccessGroups_Casetype] contains a bad value: Must not be null: caseGroupIdTemplate
               actualResponse.body contains a bad value: jurisdictions[BEFTA_MASTER] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_2__X__null] contains a bad value: roles[FT_CaseAccessGroups] contains a bad value: Must not be null: groupRoleName
               actualResponse.body contains a bad value: jurisdictions[BEFTA_MASTER] contains a bad value: accessTypes[OGD_DWP_PROFILE__X__BEFTA_SOLICITOR_2__X__null] contains a bad value: roles[FT_CaseAccessGroups] contains a bad value: Must not be null: caseGroupIdTemplate
@patelila patelila merged commit d188077 into CCD-5322_retrieve_associated_latest_CaseTypeId Aug 15, 2024
2 of 3 checks passed
@patelila patelila deleted the CCD-5647_Mismatch branch August 15, 2024 13:54
ankita-srivastava009 pushed a commit that referenced this pull request Nov 12, 2024
…essTypeRoles associated for CaseTypeId (#1468)

* Changes so easy to run single FT

* Using PropertyNamingStrategies.SnakeCaseStrategy because of c.f.j.d.PropertyNamingStrategy$SnakeCaseStrategy PropertyNamingStrategy.SnakeCaseStrategy is used but it has been deprecated due to risk of deadlock. Consider using PropertyNamingStrategies.SnakeCaseStrategy instead. See FasterXML/jackson-databind#2715 for more details.

* changes to query for POST /retrieve-access-types does retrieve AccessType and AccessTypeRoles associated for CaseTypeId

* FT for multiple jurisdiction and removing accessType (multiple) versionsfor POST /retrieve-access-types does retrieve AccessType and AccessTypeRoles associated for CaseTypeId

* removed as commited by mistake

* Update build.gradle revert version

To check if tests pass and not get the json parser error

* fix for error Errror at ✽.an appropriate test context as detailed in the test data source(file:///Users/ilapatel/Documents/Work/repos/ccd-definition-store-api/aat/src/aat/resources/features/F-082/F-082.feature:7)
              Caused by: com.fasterxml.jackson.core.JsonParseException: Unexpected character ('{' (code 123)): was expecting double-quote to start field name
               at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 69, column: 13]
                  at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:2481)

* Modified FT 110.6

* CCD-test-definition using CCD_BEFTA_RM_CT_JURISDICTION1 which has cast_type removed and Modified FT 110.1a

* CCD-test-definition using CCD_BEFTA_RM_CT_JURISDICTION1 which has cast_type removed and Modified FT 110.1a

* Version change CCD-test-definition using CCD_BEFTA_RM_CT_JURISDICTION1 which has cast_type removed and Modified FT 110.1a

* remove mistaken typeo

* empty commit to trigger build

* version change for ccd-test-definition

* Fixing ERROR [main] uk.gov.hmcts.befta.util.MapVerifierjava.lang.NullPointerException: Cannot invoke "Object.toString()" because "idElementValue" is null

* Fix for `__elementId__` to field 'accessTypes.roles

* Fix for `__elementId__` to field 'accessTypes.roles

* Fix for `__elementId__` to field 'accessTypes.roles

* Fix Failed FT's

* Fix Failed FT's

* Ccd 5647 mismatch for CCD-5233 (#1494)

* version bump +  Missing bits +  spelling typo

* Change roles to ordered

* changed Respondant to Respondent

* changed Respondant to Respondent

* changed Respondant to Respondent

* empty commit to trigger build

* channged ordering and caseType name

* changed ordering and caseType name

* changed ordering and caseType name

* empty commit to trigger build

* changed ordering and caseType name

* changed ordering and caseType name

* Use pr-1468 instead of pr-575
and ccd-data-store-api-pr-2462-es-master instead of ccd-data-store-api-pr-1260-es-master

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* ordered ordering changed
and outputing env.DEFINITION_STORE_URL_BASE

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* reverted ordering as pipeline complaining

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* added checkstyle

* Changing the order

* Changing the order

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* revert change to be same as master

* use  ccd-data-store-api-pr-2472-es-master

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* change order as @F-080 @S-080.1 FT test fails as it is expecting ordered response

* change order as @F-080 @S-080.1 FT test fails as it is expecting ordered response

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

* empty commit to trigger build

---------

Co-authored-by: Dinesh Patel <[email protected]>
Co-authored-by: RebeccaBaker <[email protected]>
Co-authored-by: bharatkumarpatel1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable_keep_helm keep-helm Do Not Uninstall Helm Release on Success ns:ccd prd:ccd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants