Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable managed cert on custom endpoint with native tf resource #112

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Enable managed cert on custom endpoint with native tf resource #112

merged 1 commit into from
Jan 26, 2022

Conversation

msl8r
Copy link
Contributor

@msl8r msl8r commented Jan 26, 2022 •
edited
Loading

Change description

  • Upgraded azurerm version to latest (v2.93.1)
  • Used newly available user_managed_https block in azurerm_cdn_endpoint_custom_domain terraform resource configure the certificate for the endpoint.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@msl8r msl8r requested a review from a team as a code owner January 26, 2022 15:49
@msl8r msl8r requested a review from timja January 26, 2022 15:54
timja
timja approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you test it in sbox first with one that's already enabled. in case it fails when it's already enabled

@msl8r msl8r merged commit c37a02a into master Jan 26, 2022
@msl8r msl8r deleted the CDN_custom_endpoint_https branch January 26, 2022 16:06
msl8r added a commit that referenced this pull request Jan 27, 2022
@msl8r
Revert "Deploy enable https custom endpoint with native tf resource (#…
7522696 
…112)"

This reverts commit c37a02a.
msl8r added a commit that referenced this pull request Jan 27, 2022
@msl8r
Revert cdn changes (#115)
c642a80 
* Deploy enable https custom endpoint with native tf resource

* Revert "Deploy enable https custom endpoint with native tf resource (#112)"

This reverts commit c37a02a.

* Update init.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msl8r @timja