Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select musics on search #4

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Select musics on search #4

merged 4 commits into from
Nov 13, 2022

Conversation

imwezz
Copy link
Contributor

@imwezz imwezz commented Nov 12, 2022

Play command now have a select menu so the user can choose the music

@imwezz
Copy link
Contributor Author

imwezz commented Nov 12, 2022

@hmes98318

@hmes98318
Copy link
Owner

Using url will also pop up the select menu.

playurl

@hmes98318
Copy link
Owner

hmes98318 commented Nov 12, 2022 •
edited
Loading

Play command now have a select menu so the user can choose the music

@Darkzx0,
I want play is simple and fast search, search is a detailed search

Therefore, this function may be more suitable for search command.

@imwezz
Copy link
Contributor Author

imwezz commented Nov 12, 2022

Using url will also pop up the select menu.

Fixed

@imwezz
Copy link
Contributor Author

imwezz commented Nov 12, 2022 •
edited
Loading

Play command now have a select menu so the user can choose the music

@Darkzx0, I want play is simple and fast search, search is a detailed search

Therefore, this function may be more suitable for search command.

@hmes98318, ok, I moved the changes to the search command

@imwezz imwezz changed the title Select musics on play Select musics on search Nov 12, 2022
@hmes98318 hmes98318 added the enhancement New feature or request label Nov 13, 2022
@hmes98318
Copy link
Owner

hmes98318 commented Nov 13, 2022 •
edited
Loading

@hmes98318, ok, I moved the changes to the search command

@Darkzx0, I found a bug and fixed it. (df5a361)

@hmes98318 hmes98318 merged commit e7fcc98 into hmes98318:main Nov 13, 2022
Spacey4K pushed a commit to Spacey4K/music-disc that referenced this pull request Jan 18, 2023
@hmes98318
Merge pull request hmes98318#4 from Darkzx0/main
c3206d3 
Select musics on search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imwezz @hmes98318