Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2] Setup CICD pipelines #39

Merged
merged 14 commits into from
Mar 9, 2023
Merged

[#2] Setup CICD pipelines #39

merged 14 commits into from
Mar 9, 2023

Conversation

hoangnguyen92dn
Copy link
Owner

@hoangnguyen92dn hoangnguyen92dn commented Mar 6, 2023

Close #2

What happened 👀

  • Setup CI pipelines to verify the new updates before merging to develop branch
  • Setup CD to deploy Android build to Firebase and iOS build to TestFlight

Insight 📝

  • Add .env and .env.staging to Github's Secrets
  • Update the pipelines for deployment
    • For Android:

      • Create a new Service Account then add it to Github's Secrets
      • Create new project on Firebase console for App Distribution
      • Add nimble group for testers
        image
    • For iOS:

image

Issue: Since my laptop limitation, I can't install XCode to verify iOS build, the deployment for iOS can't be tested currently

Proof Of Work 📹

Android build deployment 🚀

iOS build deployment 🚀

@hoangnguyen92dn hoangnguyen92dn self-assigned this Mar 6, 2023
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 6, 2023 10:19 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 03:43 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 03:43 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #39 (742594a) into develop (f09b615) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #39   +/-   ##
========================================
  Coverage    19.23%   19.23%           
========================================
  Files            3        3           
  Lines           52       52           
========================================
  Hits            10       10           
  Misses          42       42           
Flag Coverage Δ
unittests 19.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hoangnguyen92dn
Copy link
Owner Author

hoangnguyen92dn commented Mar 7, 2023

@Wadeewee I am facing this issue when executing fastlane on my local, and it requires Xcode to verify the version. Please help me to verify this with XCode on your local (Refer: https://developer.apple.com/library/archive/qa/qa1827/_index.html) 😢 Otherwise, we could skip iOS deployment for now.

image

@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 04:28 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn marked this pull request as ready for review March 7, 2023 04:30
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 09:28 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 09:28 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 09:44 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 7, 2023 09:44 — with GitHub Actions Inactive
@Wadeewee
Copy link
Collaborator

Wadeewee commented Mar 8, 2023

@Wadeewee I am facing this issue when executing fastlane on my local, and it requires Xcode to verify the version. Please help me to verify this with XCode on your local (Refer: https://developer.apple.com/library/archive/qa/qa1827/_index.html) 😢 Otherwise, we could skip iOS deployment for now.

image

@hoangnguyen92dn Here's the result when I tried executing Fastlane on my local 👇 It works fine for the step increasing the version without verifying the version in Xcode. 🤔

Screen Shot 2566-03-07 at 21 12 27

But I got this error instead 👇

Screen Shot 2566-03-07 at 21 12 00

I guess we need to update the name in project.pbxpro

@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 03:28 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 03:28 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 03:34 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 03:34 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 08:02 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 08:02 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 09:52 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 10:00 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 8, 2023 10:00 — with GitHub Actions Inactive
Base automatically changed from chore/1-setup-project to develop March 9, 2023 02:06
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging March 9, 2023 02:06 — with GitHub Actions Inactive
Copy link
Collaborator

@Wadeewee Wadeewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hoangnguyen92dn hoangnguyen92dn merged commit dab4511 into develop Mar 9, 2023
@hoangnguyen92dn hoangnguyen92dn deleted the chore/2-setup-cicd branch March 10, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants