Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#27][#28][UI][Integrate] As a user, I can see multiple selects answer #71

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

hoangnguyen92dn
Copy link
Owner

@hoangnguyen92dn hoangnguyen92dn commented Apr 19, 2023

Close #27
Close #28

What happened 👀

Add multiple choices answer view type

Insight 📝

  • Add pick field from API response to determine single/multiple choices
  • Add new Multiple Choices View
    Note: I tried the ListWheelScrollView but the CheckBox doesn't notify the state changes

Proof Of Work 📹

SVID_20230420_142507_1.mp4

Integration test passed ✅

image

@hoangnguyen92dn hoangnguyen92dn self-assigned this Apr 19, 2023
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 19, 2023 09:54 — with GitHub Actions Inactive
@manh-t
Copy link
Collaborator

manh-t commented Apr 20, 2023

@hoangnguyen92dn as I check the PoW, we cannot tick the checkbox if its index is not selected. With this implementation, we have to scroll to the item, then tick its checkbox to select the option, which is complex in term of UX 😂 . Can we update it to:

  • Showing all items linearly
  • The user can tick any checkboxes to select that option.
  • If there is a long list of selection, the list can be scrolled.

@hoangnguyen92dn
Copy link
Owner Author

@manh-t The design confused me with the unselected item so I thought the behavior is similar to the dropdown answer. Let me update then.
image

@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 20, 2023 07:26 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 20, 2023 07:26 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 20, 2023 07:27 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #71 (4eac70b) into develop (f05c03a) will decrease coverage by 0.98%.
The diff coverage is 17.74%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
- Coverage    33.53%   32.55%   -0.98%     
===========================================
  Files           72       76       +4     
  Lines         1163     1244      +81     
===========================================
+ Hits           390      405      +15     
- Misses         773      839      +66     
Flag Coverage Δ
unittests 32.55% <17.74%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/api/response/survey_question_response.dart 100.00% <ø> (ø)
lib/ui/questions/survey_answer_view.dart 0.00% <0.00%> (ø)
lib/ui/questions/survey_questions_widget_id.dart 0.00% <ø> (ø)
lib/widget/answer_multiple_choices.dart 0.00% <0.00%> (ø)
lib/model/selection_answer_type_model.dart 75.00% <75.00%> (ø)
...b/api/response/selection_answer_type_response.dart 100.00% <100.00%> (ø)
lib/model/survey_question_model.dart 95.83% <100.00%> (+0.59%) ⬆️
lib/ui/questions/survey_question_ui_model.dart 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Impacted Files Coverage Δ
lib/api/response/survey_question_response.dart 100.00% <ø> (ø)
lib/ui/questions/survey_answer_view.dart 0.00% <0.00%> (ø)
lib/ui/questions/survey_questions_widget_id.dart 0.00% <ø> (ø)
lib/widget/answer_multiple_choices.dart 0.00% <0.00%> (ø)
lib/model/selection_answer_type_model.dart 75.00% <75.00%> (ø)
...b/api/response/selection_answer_type_response.dart 100.00% <100.00%> (ø)
lib/model/survey_question_model.dart 95.83% <100.00%> (+0.59%) ⬆️
lib/ui/questions/survey_question_ui_model.dart 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

lib/widget/answer_multiple_choices.dart Outdated Show resolved Hide resolved
lib/widget/answer_multiple_choices.dart Outdated Show resolved Hide resolved
lib/widget/answer_multiple_choices.dart Outdated Show resolved Hide resolved
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 20, 2023 08:20 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to staging April 20, 2023 08:20 — with GitHub Actions Inactive
@hoangnguyen92dn hoangnguyen92dn requested a review from manh-t April 20, 2023 08:20
@hoangnguyen92dn hoangnguyen92dn merged commit 9bbdb81 into develop Apr 21, 2023
@hoangnguyen92dn hoangnguyen92dn deleted the feature/27-multiple-selects-answer branch April 21, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integrate] As a user, I can see multiple selects answer [UI] As a user, I can see multiple selects answer
3 participants