Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#408 Added List View to Progress Dashboard #231

Merged
merged 14 commits into from
Dec 10, 2024

Conversation

tanemlu
Copy link
Contributor

@tanemlu tanemlu commented Nov 18, 2024

Added a list view to the progress dashboard.

The view mode is also saved into the user settings so that they are stored persistently.

@tanemlu tanemlu requested a review from jggoebel November 18, 2024 14:58
@jggoebel
Copy link
Member

Will fix hobbyfarm/hobbyfarm#408

@@ -0,0 +1,70 @@

<clr-datagrid>
<clr-dg-column [clrDgField]="'progress'" class="color">Progress</clr-dg-column>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [clrDgField]="'progress'" can be removed. This only makes the field filterable by the progress attribute, however as this is displayed as a bar it does not need to be filtered

@jggoebel jggoebel merged commit 15d1ecc into hobbyfarm:master Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants