Don't use ANSI calls in QgisUntwine #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While untwine works ok with accented filenames as a command line tool, it is still failing when run within QGIS on windows.
There problem is the hard coded ANSI variants of windows calls in
QgisUntwine_win.cpp
(STARTUPINFOA
andCreateProcessA
).Reverting the dirty fix from qgis/QGIS@8a94723 and using the generic
CreateProcess
while expanding the used filenames throughuntwine::os::toNative()
should finally fix the issue.