Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ANSI calls in QgisUntwine #191

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Feb 18, 2025

While untwine works ok with accented filenames as a command line tool, it is still failing when run within QGIS on windows.
There problem is the hard coded ANSI variants of windows calls in QgisUntwine_win.cpp (STARTUPINFOA and CreateProcessA).

Reverting the dirty fix from qgis/QGIS@8a94723 and using the generic CreateProcess while expanding the used filenames through untwine::os::toNative() should finally fix the issue.

@abellgithub
Copy link
Collaborator

Would it be easier for you to just take this API/startup code and put it in your repo?

@uclaros
Copy link
Contributor Author

uclaros commented Feb 18, 2025

It's probably easier as it is now, we just grab all untwine source and place it in our external dir.
We shouldn't need to tamper with this file again, as it was just broken from the beginning (I mean the CreateProcessA() usage).

@abellgithub abellgithub merged commit 2058b7e into hobuinc:main Feb 18, 2025
6 checks passed
@uclaros uclaros deleted the fix-qgis-utf branch February 18, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants