Minor notes

holdenk · May 11, 2024 · 27c5793 · 27c5793
1 parent b97979d
commit 27c5793
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pipelinecompare/table_compare.py b/pipelinecompare/table_compare.py
@@ -27,6 +27,7 @@
                     help='Tolerance for % of different rows')
 
 
+# Future improvement: compare only the changed partitions
 def compare_tables(control, target):
     if control.schema != target.schema:
         control.printSchema()
@@ -50,7 +51,7 @@ def compare_tables(control, target):
         missing_rows = control.subtract(target)
         new_rows = target.subtract(control)
     except Exception as e:
-        # TODO: only convert the columns that need to be converted.
+        # Improvement: only convert the columns that need to be converted.
         eprint(f"Warning converting all to strings.... {e}")
         columns = control.columns
         for c in columns: