consensus/beacon: simplify header split #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic for splitting headers.
Before we verify the header batch in
VerifyHeaders
function, we should strictlysplit the provided headers into two parts: one before the ttd(including the terminal
block) and one after the ttd.
Then we can hold the truth that the tds of pre-headers(except potential terminal
block) don't exceed the ttd, no matter the header difficulty is correct or not
(can be fake, but will be detected later in verification). And also td tds of post-headers
must all exceed the ttd(since the assumed difficulty is zero).
Then we can deliver the separated headers into corresponding verification functions
which will detect all invalid headers, e.g. difficulty is invalid.