Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon_PLM: Parser Dumps Buffered String If Interface Busy Message Received #158

Closed
krkeegan opened this issue Apr 6, 2013 · 0 comments
Closed

Insteon_PLM: Parser Dumps Buffered String If Interface Busy Message Received #158

krkeegan opened this issue Apr 6, 2013 · 0 comments
Assignees
@krkeegan
Labels
bug

Comments

@krkeegan
Copy link
Collaborator

krkeegan commented Apr 6, 2013

Identified by Chris Dragon on the mailing list. In his example, the message buffer contained

151502

Where 02 was the fragment of the start of another message. The parser correctly determined that this was an interface busy message, but it dumped the entire buffer, rather than just the first byte.

I have taken an excerpt of the code and confirmed that this is indeed occurring. Should be a relatively simple fix to remove the NACK and place the remaining buffer into the data_fragment.
@ghost ghost assigned krkeegan Apr 6, 2013
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Apr 6, 2013
@krkeegan
Insteon_PLM: Fix Error in Message Parser Dumping Buffer on Busy
0f2e11d 
Solves issue hollie#158 identified by Chris Dragon

This will trim the leading "15" bytes from the data.  If anything is left it will be placed into the message fragment to be read next time.
@krkeegan krkeegan mentioned this issue Apr 6, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krkeegan krkeegan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan