Merge pull request no-types#1 from vbisrikkanth/master

Bugfixes and update

DESCRIPTION

@@ -1,16 +1,16 @@
 Package: RagGrid
 Type: Package
-Title: A Wrapper of the JavaScript Library 'DataTables'
+Title: A Wrapper of the JavaScript Library 'ag-Grid'.
 Version: 0.1.1
 Authors@R: c(
     person("Praveen", "N", email = "[email protected]", role = c("aut", "cre")),
     person("Srikkanth", "M",email = "[email protected]",role = c("aut", "ctb"))
     )
 Maintainer: Praveen N<[email protected]>, Srikkanth M<[email protected]>
 Description: Data objects in R can be rendered as HTML tables using the
-    JavaScript library 'DataTables' (typically via R Markdown or Shiny). The
-    'DataTables' library has been included in this R package. The package name
-    'DT' is an abbreviation of 'DataTables'.
+    JavaScript library 'ag-grid' (typically via R Markdown or Shiny). The
+    'ag-grid' library has been included in this R package. The package name
+    'RagGrid' is an abbreviation of 'R agGrid'.
 URL: https://github.com/praveenn-vbi/RagGrid/
 BugReports: https://github.com/praveenn-vbi/RagGrid/issues
 License: MIT

README.md

@@ -1,2 +1,19 @@
 # R agGrid
 R interface to ag-grid.
+
+This package provides a function `RagGrid()` to display R data via the [ag-grid](https://www.ag-grid.com/) library.
+
+## Installation
+
+We're still actively developing and hopefully it'll be available in CRAN soon. 
+
+But feel free to install from github.
+You may install the development version using **devtools**:
+
+```r
+
+# the development version
+devtools::install_github('praveenn-vbi/RagGrid')
+
+# then try DT::datatable(iris) as a hello world example
+```

inst/htmlwidgets/RagGrid.js

@@ -7,8 +7,8 @@ HTMLWidgets.widget({
   factory: function(el, width, height) {
     let gridOptions={};
     // TODO: define shared variables for this instance
-    var sel_handle = new crosstalk.SelectionHandle();
-    var filter_handle = new crosstalk.FilterHandle();
+    const sel_handle = new crosstalk.SelectionHandle();
+    const filter_handle = new crosstalk.FilterHandle();
     sel_handle.on("change", function(e) {
       if (e.sender !== sel_handle) {
         // scatter.clearBrush(); 
@@ -55,8 +55,11 @@ HTMLWidgets.widget({
                 sel_handle.set(selectionKeys);
             }
          }
-         sel_handle.setGroup(x.settings.crosstalk_group);
-         filter_handle.setGroup(x.settings.crosstalk_group);
+
+         if(x.settings.crosstalk_group){
+           sel_handle.setGroup(x.settings.crosstalk_group);
+           filter_handle.setGroup(x.settings.crosstalk_group);
+         }
 
          gridOptions=Object.assign(defaultGridOptions,x.gridOptions);
          const rowHeaders = Object.keys(data);
@@ -77,7 +80,9 @@ HTMLWidgets.widget({
             rowHeaders.forEach((rowHeader)=>{
                 rowData[filedRowHeaderMap[rowHeader]] = data[rowHeader][rowIndex];
             });
-            rowData.ctKey=x.settings.crosstalk_key[rowIndex];
+            if(x.settings.crosstalk_key){
+               rowData.ctKey=x.settings.crosstalk_key[rowIndex];
+            }
             rowDataList.push(rowData);
          }
          if(x.licenseKey){