Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build guide: validation #520

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

Build guide: validation #520

wants to merge 49 commits into from

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Feb 4, 2025

Closes #475 .

This PR depends on #516 and #517 . Don't review until they're merged.

So while this PR reflects my attempts to simplify the work I'm doing on the Build Guide, it doesn't incorporate the feedback I got today to simplify even more. So it does do some explanatory stuff that may or may not be necessary. Feel free to offer feedback on whether it's too much information, with the caveat that I'll be using that feedback in future PRs and will probably leave this one as it is, because it's already been written and it's probably useful information. (That said, if you feel it gets in the way, please explicitly say that you think it should be removed.)

Covers:

  • validate callback
  • genesis_self_check callback
  • must_get_*
  • a few design considerations for validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practical guide for using Membrane Proof
1 participant