This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
swarm travis #775
Merged
zippy
merged 124 commits into
holochain:develop
from
thedavidmeister:2018-12-18-appveyor
Dec 19, 2018
Merged
swarm travis #775
zippy
merged 124 commits into
holochain:develop
from
thedavidmeister:2018-12-18-appveyor
Dec 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain-rust into 2018-12-18-appveyor
lucksus
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Is feature "broken-tests" a thing? I can't find a custom definition for that...
zippy
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!!
@lucksus iirc https://doc.rust-lang.org/1.5.0/book/conditional-compilation.html means we can send |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
cfg( feature = "broken-tests")
flag so we can track and repair slow/flaky/broken tests in a structured way without just commenting them straight outnot(windows)
attributes with this insteadobviously this only really works while we have many builds
these changes essentially make it so we can take advantage of the 13 builds we have and keep them busy adding value while we wait for upstream fixes
reason for not appveyor
followups
rust-docs
is now the slowest thing we do by far :( this is going back and forward upstream--minimal
flag torustup-init
rust-lang/rustup#907notes duing testing
pros
cons
notes
appveyor is going nowhere
downloading travis-docs is the worst! it adds 8 minutes to install and downloads 100's of mb
thinlto is much better than --release
cold 30 mins on wasm:
really want this Add a
--minimal
flag torustup-init
rust-lang/rustup#907!! will drop times across the board by 5+ minutes