Two way op flow #41
Merged
Two way op flow #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
force-pushed
the
two-way-op-flow
branch
from
829c935 to
9046508
Compare
neonphog
reviewed
Dec 3, 2024
neonphog
previously approved these changes
Dec 3, 2024
|
Sorry, I extracted this from other changes and it's not as ready as I thought. I'll get this updated :) |
|
Okay, tests fixed, this should be good to go |
ThetaSinner
commented
Dec 3, 2024
neonphog
reviewed
Dec 3, 2024
…onverted to a `StoredOp`
Co-authored-by: David Braden <[email protected]>
ThetaSinner
force-pushed
the
two-way-op-flow
branch
from
ca5bc67 to
74c1135
Compare
jost-s
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed needing to treat incoming
MetaOps separately from ops that we have persisted. We don't know the internal structure of incoming op data. It needs to go to the host to be decoded. Then within Kitsune, we do need to be able to organize persisted ops by timestamp and op ID. Plus we don't want to be gossiping data until we've been able to store it and will be able to respond to requests for it.So, this PR proposes that we have different types and require the host to be able to communicate the op data back to us with its timestamp.
See #20 (comment)