Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SODIUM_DIST_DIR variable #249

Merged
merged 5 commits into from
Mar 4, 2025
Merged

Use SODIUM_DIST_DIR variable #249

merged 5 commits into from
Mar 4, 2025

Conversation

matthme
Copy link
Collaborator

@matthme matthme commented Mar 4, 2025

This PR downloads libsodium from another source and uses the SODIUM_DIST_DIR variable, in order to circumvent download issues in CI.

@matthme matthme requested a review from a team March 4, 2025 17:02
ThetaSinner
ThetaSinner approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there an issue open to track figuring out the build against a vcpkg provided libsodium?

@matthme
Copy link
Collaborator Author

matthme commented Mar 4, 2025

Created one now: #250

@matthme matthme merged commit d83e701 into develop Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthme @ThetaSinner