Feat/app store #31
Merged
Feat/app store #31
+487
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthme
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Some feedback:
- installing an app does not succeed for me (no error it just never finishes)
- install button in the dialog when installing an app from the appstore can currently be pressed multiple times
- input field text is not centered
- The arrow button in initial password setup does not do anything, only with ENTER one can continue
- "What do you want to launch" is mixed up with "Search for apps" in the search bars I think
- Install Happ button is deactivated when a file is selected so it's not possible to install a happ from the settings view (from filesystem)
- let's update the kando that's being shipped by default to https://github.com/holochain-apps/kando/releases/download/v0.8.18/kando.webhapp by changing the "fetch:default-apps" script in package.json accordingly
|
Not everything necessarily needs to get into that PR I think but the things that are not working should (like installing apps and setting up password via button) such that we always have a functional version on develop. |
mrruby
force-pushed
the
feat/app-store
branch
from
d044269 to
3bce92b
Compare
mrruby
force-pushed
the
feat/app-store
branch
from
3bce92b to
15ce77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.