Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/binaries fix #32

Merged
merged 10 commits into from
Feb 1, 2024
Merged

Feat/binaries fix #32

merged 10 commits into from
Feb 1, 2024
+167 −62

Conversation

mrruby
Copy link
Contributor

@mrruby mrruby commented Feb 1, 2024

No description provided.

@mrruby mrruby requested a review from matthme February 1, 2024 12:55
matthme
matthme approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@matthme matthme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Maybe the error message could be a bit more elaborate at some point (e.g. which binary is missing exactly). And I think we should decouple the building of lair and holochain binaries as said elswehere, maybe in its own repository.

@mrruby mrruby merged commit 2400263 into develop Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthme matthme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrruby @matthme