check UI hashes Part 2 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthme
commented
Mar 18, 2024
matthme
commented
- computes the hashes from the bytes in memory instead of writing them to a zip file in the temp directory
- adds better error handling when checking hashes before serving asset to happ window
- adds test for IntegrityChecker
…is requested that's not in the list of originally installed files
mrruby
approved these changes
Mar 18, 2024
ThetaSinner
reviewed
Mar 18, 2024
src/main/tests/integrityChecker.ts
Outdated
| iC.storeToSignedJSON(filePath, writeData); | ||
| // tamper with file | ||
| const readString = fs.readFileSync(filePath, 'utf-8'); | ||
| fs.writeFileSync(filePath, readString + 'tampered'); |
There was a problem hiding this comment.
I's be careful to maintain the structure of the file here. This could (and I think will) throw because the content is no longer valid JSON. It's the signature that's important here so it needs to be that error that gets thrown
There was a problem hiding this comment.
Okay, should be addressed with the latest commit
ThetaSinner
reviewed
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.