feat: Results analysis #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
force-pushed
the
feat/wind-tunnel-results-analysis
branch
from
9365e09 to
574cd4e
Compare
ThetaSinner
force-pushed
the
feat/wind-tunnel-results-analysis
branch
from
625101c to
bd95ac8
Compare
cdunster
requested changes
Oct 22, 2024
neonphog
reviewed
Oct 22, 2024
jost-s
previously approved these changes
Oct 23, 2024
|
Turns out there was a problem with the data data. I hadn't included the scenario name in the fingerprint so scenarios with the same settings were getting the same fingerprint... Which isn't right! So I've sorted that now and added some tests/checks to stop things like that happening again |
ThetaSinner
force-pushed
the
feat/wind-tunnel-results-analysis
branch
from
c339bdd to
884cf54
Compare
cdunster
previously approved these changes
Oct 24, 2024
ThetaSinner
force-pushed
the
feat/wind-tunnel-results-analysis
branch
from
db2cab7 to
7424100
Compare
cdunster
previously approved these changes
Oct 25, 2024
Co-authored-by: Callum Dunster <[email protected]>
Co-authored-by: Callum Dunster <[email protected]>
Co-authored-by: Callum Dunster <[email protected]>
This reverts commit baf2ea6.
Co-authored-by: Callum Dunster <[email protected]>
Co-authored-by: Callum Dunster <[email protected]>
Co-authored-by: Callum Dunster <[email protected]>
ThetaSinner
force-pushed
the
feat/wind-tunnel-results-analysis
branch
from
dc84124 to
78d023f
Compare
cdunster
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is ready to go as a first draft. I do think that some of the way I'm expecting runIds to be consistent across nodes and that we can know information about how many agents participated and ended from one node is specific to Local/TryCP. This will need adjusting if we go to a distributed run approach. However, I believe that the data analysis is reasonable in a distributed case because that shouldn't be assuming anything about how the scenario was run.
Whether the metrics are exactly what we need is a question for when we start asking questions based on them. But we can get some basic insights and track performance over time with this.
This will still need integrating with the performance test pipeline. That's not straight forward enough that I think it should happen on this PR.