Merge pull request #352 from holographxyz/fix/HAL-03-recover-jobs-checks

Fix HAL-03 recoverJobs delete job before execute it
holographxyz · Aug 20, 2024 · 3c5fddc · 3c5fddc
2 parents 7babd73 + 66394bd
commit 3c5fddc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/HolographOperator.sol b/src/HolographOperator.sol
@@ -216,9 +216,9 @@ contract HolographOperator is Admin, Initializable, HolographOperatorInterface {
   function recoverJob(bytes calldata bridgeInRequestPayload) external payable onlyAdmin {
     bytes32 hash = keccak256(bridgeInRequestPayload);
     require(_failedJobsV2[hash], "HOLOGRAPH: invalid recovery job");
+    delete (_failedJobsV2[hash]);
     (bool success, ) = _bridge().call{value: msg.value}(bridgeInRequestPayload);
     require(success, "HOLOGRAPH: recovery failed");
-    delete (_failedJobsV2[hash]);
   }
 
   /**

diff --git a/test/foundry/utils/Constants.sol b/test/foundry/utils/Constants.sol
@@ -41,7 +41,7 @@ library Constants {
   }
 
   function getHolographOperator() internal pure returns (address) {
-    return address(0x0cA0cA1238cD14cb9A81cA68249B84655907B7A5);
+    return address(0xb03ee8D15C046b25eD006e247f71d6F27920624f);
   }
 
   function getHolographOperatorProxy() internal pure returns (address) {