Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: cross-chain multisig implementation #120

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ACC01ADE
Copy link
Contributor

@ACC01ADE ACC01ADE commented Dec 27, 2022

Describe Changes

Proposing a cross-chain multisig implementation.

  • Leveraging HolographGeneric to create a custom CrossChainMultisig implementation
  • Using bridgeIn and bridgeOut to send SecurePackets with multisig-approved data

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Hardhat tests are passing

@ACC01ADE ACC01ADE changed the title Feature/cross chain multisig Proposal: cross-chain multisig implementation Dec 27, 2022
@ACC01ADE ACC01ADE marked this pull request as ready for review December 27, 2022 08:25
Copy link
Contributor

@alexanderattar alexanderattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need more context on what the planned use for this is. Maybe it was explained earlier and I missed it or need my memory refreshed after the holiday break. Besides that the changes don't really seem to affect current contracts so I think that should be okay. Let's chat about this when there's time @ACC01ADE

@sogoiii sogoiii marked this pull request as draft February 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants