Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/holo 1363 deploy v2 for develop env #227

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Feature/holo 1363 deploy v2 for develop env #227

merged 4 commits into from
Feb 7, 2024

Conversation

alexanderattar
Copy link
Contributor

@alexanderattar alexanderattar commented Feb 6, 2024 •
edited
Loading

Describe Changes

  • Deploy a new develop environment for all supported networks
  • Remove deprecated scripts
  • Add some more logs to the deploy script
  • Set the correct deployer key if not hardware enabled
  • Add env variable for gas price override and logic to grab it in the helpers file
  • As if deployer wants to continue after logging deployment settings

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Hardhat tests are passing

@alexanderattar alexanderattar marked this pull request as ready for review February 7, 2024 20:44
sogoiii
sogoiii reviewed Feb 7, 2024
View reviewed changes
deploy/01_sources.ts
console.log('Deployer address:', deployerAddress);
console.log(`Deploying to network: ${hre1.network!.name}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderattar i like this alot 👍

sogoiii
sogoiii approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexanderattar alexanderattar merged commit d3d600e into develop Feb 7, 2024
2 checks passed
@alexanderattar alexanderattar deleted the feature/HOLO-1363-deploy-v2-for-develop-env branch February 7, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogoiii sogoiii sogoiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderattar @sogoiii