-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade HolographDropERC721 #228
Merged
sogoiii
merged 27 commits into
develop
from
feature/HOLO-1364-upgrade-holograph-drop-erc721
Feb 29, 2024
Merged
Upgrade HolographDropERC721 #228
sogoiii
merged 27 commits into
develop
from
feature/HOLO-1364-upgrade-holograph-drop-erc721
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogoiii
reviewed
Feb 14, 2024
3 tasks
sogoiii
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BravoNatalie
approved these changes
Feb 24, 2024
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Changes
0xeA7f4C52cbD4CF1036CdCa8B16AcA11f5b09cF6E
holographMintFee
fee into the treasury (initially set to $1.00)To run tests:
yarn ganache-x2
oryarn anvil
npx hardhat deploy --network localhost
forge test
Checklist before requesting a review