Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HolographDropERC721 #228

Merged
merged 27 commits into from
Feb 29, 2024

Conversation

alexanderattar
Copy link
Contributor

@alexanderattar alexanderattar commented Feb 7, 2024

Describe Changes

  • Adds HolographDropERC721V2
  • Adds a new deployment script for it
  • Adds the new contract to the registry
  • Update the version to 2 (NOTE: The upgrade is incompatible from previous version therefore making it a MAJOR upgrade)
    • I thought about changing this to a uint32, but because it's a pure function the optimization would be minimal.
  • Remove OpenSea operator filter registry because this royalty enforcement mechanism has been deprecated: https://opensea.io/blog/articles/creator-fees-update
    • Updates the deployment scripts to be compatible with the above
  • Updates the price oracle proxy reference to the latest address 0xeA7f4C52cbD4CF1036CdCa8B16AcA11f5b09cF6E
  • Moves the holographMintFee fee into the treasury (initially set to $1.00)
  • Adds functions for getting and setting the mint fee
  • Adds tests to check the new functions

To run tests:

  1. run yarn ganache-x2 or yarn anvil
  2. npx hardhat deploy --network localhost
  3. forge test

image

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Hardhat tests are passing

@alexanderattar alexanderattar changed the title Initial changes for upgrading HolographDropERC721 Upgrade HolographDropERC721 Feb 13, 2024
@alexanderattar alexanderattar marked this pull request as ready for review February 14, 2024 19:38
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sogoiii sogoiii merged commit 52e1c3a into develop Feb 29, 2024
2 checks passed
@sogoiii sogoiii deleted the feature/HOLO-1364-upgrade-holograph-drop-erc721 branch February 29, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants