Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL-07 Incompatibility with non-standard ERC20 #353

Merged
merged 2 commits into from
Aug 20, 2024
Merged

HAL-07 Incompatibility with non-standard ERC20 #353

merged 2 commits into from
Aug 20, 2024

Conversation

Yashiru
Copy link
Contributor

@Yashiru Yashiru commented Aug 7, 2024 •
edited
Loading

Audit report ticket

https://www.halborn.com/portal/reports/protocol#8.7

Describe Changes

  • Updated all tokenUtility transfer to use the SafeErc20 OZ library

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Foundry tests are passing

@Yashiru Yashiru self-assigned this Aug 8, 2024
@Yashiru Yashiru changed the title HAL-07 (WIP) HAL-07 Incompatibility with non-standard ERC20 Aug 8, 2024
@Yashiru Yashiru marked this pull request as ready for review August 8, 2024 14:50
alexanderattar
alexanderattar approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@alexanderattar alexanderattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. We would need to validate that this doesn't break anything on testnet, which might be the more time consuming task at hand

sogoiii
sogoiii approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sogoiii sogoiii merged commit 7babd73 into develop Aug 20, 2024
3 checks passed
@sogoiii sogoiii deleted the fix/HAL-07-IERC20-transfers branch August 20, 2024 18:22
@alexanderattar alexanderattar mentioned this pull request Aug 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogoiii sogoiii sogoiii approved these changes

@alexanderattar alexanderattar alexanderattar approved these changes

Assignees

@Yashiru Yashiru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yashiru @sogoiii @alexanderattar