-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
20552aa
to
2c5ce2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly confused; in the diffs I don't see any changes to notebooks other than deleting them, even though the description above specifically lists changes.
Also, the intake catalog file presumably needs a newline at the end?
Yes, the diffs won't render because I removed all the metadata. You'll probably need to just view the notebook. Intake catalogs do not need a newline at the end, but I can add one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
@mmccarty I think there is a merge conflict due to the docs PR where I moved this notebook into |
79eb778
to
178b43f
Compare
@mmccarty Looks good, thanks! Hopefully we will be able to avoid specifying the |
To Do: