Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created stand-alone scripts that reproduce the plots in the docs #142

Closed
wants to merge 4 commits into from

Conversation

scaine1
Copy link
Contributor

@scaine1 scaine1 commented Mar 9, 2018

When I first started not having working examples was quite difficult. It's obvious to me now how to get the same results as the ipython magics, but at the time I recall it was quite confusing

These should be useful for people who don't or can't use the notebooks.

I tried to show a few different ways to set the plot options, i.e. globally, or locally, using dictionary or strings.

I wasn't 100% sure when to put them, so ended up putting them in the notebooks/user_guide directory.

In the docs there is a link that says "Right click to download this notebook from GitHub."

I would also suggest adding "Right click to download this script from GitHub."

…cale dependent, previous example was a bit confusing as the results looked no different
* 'master' of github.com:ioam/geoviews:
  changed scale example in Geometries notebook to use feature that is scale dependent, previous example was a bit confusing as the results looked no different (holoviz#137)
  Fixed sphinx pin in previous commit.
@jbednar
Copy link
Member

jbednar commented Mar 9, 2018

Thanks! These are clearly useful for GeoViews users, but I'd be concerned about our ability to maintain them and keep them up to date as the original versions change over time. For one thing, as we implement #121 , we'll have dozens of separate notebooks, each of which could usefully have an associated script.

Should we not just use an automatic mechanism to convert each notebook into a runnable python script, which I believe @jlstevens has prototyped if I am not making that up? Then every page could have a link saying "Right click to download this code as a notebook or as a script to try it out yourself".

@jlstevens
Copy link
Contributor

Should we not just use an automatic mechanism to convert each notebook into a runnable python script, which I believe @jlstevens has prototyped if I am not making that up?

That's right although it is (as you say) a prototype right now though if I have a chance I can clean it up (the conversion will be done using the holoviews console script).

@scaine1
Copy link
Contributor Author

scaine1 commented Mar 9, 2018

The inclusion of the .options method recently already made me think maintaining will be an issue. Having a conversion script would be heaps better!
I was making the scripts as an exercise anyway so no issue if you want to wait till conversion tool comes out.

@scaine1 scaine1 closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants