Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoloMap wrongly renders missing data #1677

Closed
wjaskowski opened this issue Jul 4, 2017 · 3 comments · Fixed by #3836
Closed

HoloMap wrongly renders missing data #1677

wjaskowski opened this issue Jul 4, 2017 · 3 comments · Fixed by #3836
Assignees
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@wjaskowski
Copy link

def sine_curve(phase, freq):
    xvals = [0.1* i for i in range(100)]
    return hv.Curve((xvals, [np.sin(phase+freq*x) for x in xvals]))

phases      = [0, 1, 2]
frequencies = [0.5, 1.0, 1.5]
curves = {(p,f):sine_curve(p,f) for p in phases for f in frequencies}
del curves[0, 1.0]
hmap = hv.HoloMap(curves, kdims=['phase', 'frequency'])
hmap

for [0, 1.0] (which is missing) renders the same as for the one previously seen (here: [0, 1.5]) while it should render an empty plot.

Screenshots:

@jlstevens jlstevens added the type: bug Something isn't correct or isn't working label Jul 4, 2017
@philippjfr philippjfr added this to the v1.9 milestone Sep 23, 2017
@philippjfr philippjfr self-assigned this Sep 23, 2017
@philippjfr philippjfr modified the milestones: v1.9, v1.10 Oct 31, 2017
@philippjfr
Copy link
Member

philippjfr commented Mar 4, 2018

Thanks, and sorry for not replying sooner. This is a somewhat tricky problem because HoloMaps only serialize plots for which there is available data, so when you hit a key that doesn't have data available there is nothing that will set the renderers to be invisible. My proposal therefore is that along with the data for all available keys the widgets additionally send the data for an empty frame, which will be shown whenever the widgets encounter a key that is missing.

@wjaskowski
Copy link
Author

wjaskowski commented Mar 4, 2018 via email

@philippjfr philippjfr modified the milestones: v1.10, v1.11 Mar 19, 2018
@philippjfr philippjfr modified the milestones: v1.11.0, v1.11.x Dec 4, 2018
@philippjfr philippjfr modified the milestones: v1.11.x, v1.12.0, v1.12.x Mar 22, 2019
@philippjfr philippjfr modified the milestones: v1.12.x, v1.13.0 Sep 22, 2019
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants