-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimensional Objects, sampling, splitting and collapsing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -66,6 +69,30 @@ def __mul__(self, other): | |||
roi_bounds=roi_bounds) | |||
|
|||
|
|||
def dimension_values(self, dim_index): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not dim_label instead of dim_index?
jlstevens
added a commit
that referenced
this pull request
May 31, 2014
Dimensional Objects, sampling, splitting and collapsing Merging now as the PR is supposed to be 100% up-to-date - we will have a few things to tidy up to get the tests working shortly.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not to be merged immediately but the core of everything already works, i.e. sampling is implemented within this new modular framework. This framework will eventually make Views easily sampleable, collapseable and convertible in addition to being sliceable and deepindexable.
The Concept
More importantly this puts us on a path of massively extending the power of DataViews by going beyond the two operations we already know about:
To a number of even more useful properties of DataViews:
The Implementation
Note: * indicates what is not yet implemented
View/Stack Types of different dimensions [indicates shape or type of data]
Stack Methods
Data/Sheet/TableStack Methods
View Methods (implemented on the dimensionality subclass, i.e. currently on DataLayer and SheetView)
Further notes:
The timeline
Basically this pull request will get us to a stage where we can leave it and not worry about having to massively change the API or the datastructures later. The real issue is that right now, we won't be able to work on this any more. However, we don't want to do all of our science based on a system that will completely change in a few months time. Changing over to the Dimensional object means that everything is in place to get all of the above working in time. The system is modular such that we can implement the missing methods as we need them until eventually every single dimension is truly sampleable, collapseable, and convertible.