Enable compute_edges with unequally spaced data #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforbes
force-pushed
the
master
branch
2 times, most recently
from
1f2b33f to
01153c8
Compare
|
Sounds great! I'll assign Philipp as a reviewer as he is the one who'll be able to reason about how your changes might affect other things (e.g casting between element types). |
|
I'm fine with making this change. It shouldn't affect anything else in terms of casting of elements and is usually a safe enough thing to do. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple modification that allows one to use
QuadMeshetc. with unevenly spaced points without having to explicitly provide the bin boundaries. This simply uses the midpoints as bin boundaries and sets the endpoints as the midpoints of the outer cells. This thus maintains the previous behaviour when equally-spaced points are provided, and now simply allows for unevenly spaced points. (See also issue #1869.)