Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprioritized array interface #2338

Merged
merged 6 commits into from
Feb 20, 2018
Merged

Deprioritized array interface #2338

merged 6 commits into from
Feb 20, 2018

Conversation

philippjfr
Copy link
Member

Finally implements #1236, this is long overdue since the ArrayInterface mostly just causes troubles due to mixed types. With this change you should only ever end up with an ArrayInterface when you pass in an NxM array explicitly.

@philippjfr
Copy link
Member Author

Should be merged after #2329. Should also reenable the Graph test that was disabled in that PR.

@philippjfr philippjfr mentioned this pull request Feb 13, 2018
Merged
@jlstevens
Copy link
Contributor

Agreed this is overdue. #2329 is now merged so those tests should be re-enabled and the tests seem to have failed right now. Maybe fixing that (or a rebase) will get the tests green so I can merge?

I'm a little worried that this change might cause problems as it affects so many things. But I also believe we really should do it now...

@philippjfr
Copy link
Member Author

I'm a little worried that this change might cause problems as it affects so many things. But I also believe we really should do it now...

It's revealing at least a few bugs caused by the ArrayInterface, which should be fixed by using the other interfaces. Tests also need updating because type comparisons are failing.

@philippjfr philippjfr force-pushed the array_interface branch 2 times, most recently from 56324c2 to 4186e68 Compare February 19, 2018 00:02
@philippjfr
Copy link
Member Author

Had to make some fixes to the testing code in nbpublisher, it errored before it could capture test data.

@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens
Copy link
Contributor

Looks good. I think this is important to do and hope it won't cause us any backwards compatibility headaches! Merging.

@jlstevens jlstevens merged commit 47dda3d into master Feb 20, 2018
@philippjfr philippjfr deleted the array_interface branch March 9, 2018 14:52
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: component: data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens