-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option error refactor #2354
Option error refactor #2354
Conversation
2926131
to
de08c2d
Compare
This is far from ready but I wanted to discuss an idea. I'd like to make option validation as strict as possible in future so you always get immediate feedback if you supplied an invalid option. By default this PR will ensure that For testing I'd want both to be enabled, which will catch any examples that are using incorrect options. |
2e9b16b
to
8d0453d
Compare
I also want to enable warnings when using |
8d0453d
to
e25e348
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Picks up where #2306 left off, completely refactoring option error handling. All methods of setting options will now either warn or error when given an invalid option. Could consider readding a skip option for the OptionsMagic, because that won't let you be explicit about the backend you're trying to set options on yet.