-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross backend style fixes #307
Conversation
The tests are failing because style inheritance doesn't seem to be working for one example in the Pandas Conversion tutorial. It seems to be an issue with style inheritance even though there are unit tests for this and simple tests work fine for me in the notebook. Strange... |
I can confirm it is the last commit that stops inheritance working in this example. However, I need that commit to get the behavior we now want... |
Sorry about the accidental merge! The latest version of magit has a 'push quickly' option that went and did this... :-( |
On the plus side, the tests all passed so maybe it was time to merge these fixes anyway. :-) I'm now going to try and add some new unit for cross backend styling. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR aims to address the problems with style pickling ahead of the 1.4 release and to allow a single object to retain styling across backends.
Edit: Really pickling is only part of the issue so I've changed to the title to reflect that the fix is for styling across backends in general.