Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link widgets with same name during embed #1543

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

philippjfr
Copy link
Member

Fixes #806
Fixes #1083

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1543 into master will decrease coverage by 0.03%.
The diff coverage is 75.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   85.63%   85.60%   -0.04%     
==========================================
  Files         146      146              
  Lines       16081    16161      +80     
==========================================
+ Hits        13771    13834      +63     
- Misses       2310     2327      +17     
Impacted Files Coverage Δ
panel/io/callbacks.py 26.02% <15.62%> (-3.39%) ⬇️
panel/reactive.py 86.43% <94.11%> (+1.06%) ⬆️
panel/io/embed.py 86.87% <100.00%> (+0.88%) ⬆️
panel/tests/io/test_embed.py 99.39% <100.00%> (+0.04%) ⬆️
panel/tests/test_links.py 98.88% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391c4c7...ae450ed. Read the comment docs.

@philippjfr philippjfr merged commit 0fe6e23 into master Aug 24, 2020
@philippjfr philippjfr deleted the embed_multiple_fix branch August 24, 2020 02:26
philippjfr added a commit that referenced this pull request Sep 17, 2020
* Link widgets with same name during embed

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Holomap and tabs misbehaves when saved as html file First tab's HoloMap slider is unresponsive
1 participant